pcntl_wait / pcntl_waitpid: Document the rusage parameter (fixes #861) #4917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
requested changes
Oct 27, 2025
There was a problem hiding this comment.
pcntl_waitid already has the parameter documented. Can you align the explanation: https://www.php.net/manual/en/function.pcntl-waitid.php?
Done |
TimWolla
reviewed
Oct 28, 2025
| print "PARENT pcntl_waitpid: No exited children.\n"; | ||
| } else { | ||
| print "PARENT pcntl_waitpid: Child PID {$deadPid} exited with status: " | ||
| . pcntl_wexitstatus($status) ."\n"; |
There was a problem hiding this comment.
The documentation for wexitstatus says:
This function is only useful if pcntl_wifexited() returned true.
So, is a wifexited call missing here? Looking more carefully at the example, it uses quite a few functions from the pcntl extension. It might make sense to include it in https://www.php.net/manual/en/pcntl.example.php instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.